Adds user -> account linking #19
Conversation
tests/client-tests.js
Outdated
| const hull = new Hull({ id: "562123b470df84b740000042", secret: "1234", organization: "test" }); | ||
|
|
||
| const scoped = hull.asAccount({ id: "123456" }); | ||
| const scoped = hull.asAccount({ name: "Hull" }); |
There was a problem hiding this comment.
Account lookup by name is not available at the moment.
We can only lookup using domain or external_id
There was a problem hiding this comment.
Okey, I've removed it from accountClaim properties and adjusted tests.
tests/client-tests.js
Outdated
| .to.have.property("sub") | ||
| .that.eql("123456"); | ||
| .to.have.property("io.hull.asAccount") | ||
| .that.eql({ name: "Hull" }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
We could had a test for account traits without using asUser to set the account name (or anything else), like this : hull.asAccount({ domain: 'hull.io' }).traits({ name: 'Hull' })
There was a problem hiding this comment.
We have one test for hull.asAccount() without user resolution. I would test traits on other place, but thanks, for pointing it out.
tests/client-tests.js
Outdated
|
|
||
| expect(scopedJwtClaims) | ||
| .to.have.property("io.hull.subjectType") | ||
| .that.eql("account"); | ||
| expect(scopedJwtClaims) | ||
| .to.have.property("io.hull.asAccount") | ||
| .that.eql({ name: "Hull" }); |
tests/client-tests.js
Outdated
| }); | ||
|
|
||
| it("should allow to link user to an existing account", () => { |
There was a problem hiding this comment.
This is not actually linking. It is just a getter to the user's account
There was a problem hiding this comment.
You're right, fixed.
use asUser with id in token when subjectType is not a user
requestExtracthandler - allow passingpathparam.asUser()and.asAccount()to returntraitsandtrack.asUser().account()method